Skip to content

This is to make sure activations for a shared action run in an invocation namespace. #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

This is to make sure activations for a shared action run in an invocation namespace. #5296

merged 1 commit into from
Jul 29, 2022

Conversation

style95
Copy link
Member

@style95 style95 commented Jul 28, 2022

Description

This is one of basic functionalities, but the test will help to guarantee it.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

Codecov Report

Merging #5296 (38d374b) into master (3014b87) will decrease coverage by 75.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5296       +/-   ##
==========================================
- Coverage   79.97%   4.57%   -75.40%     
==========================================
  Files         238     238               
  Lines       14199   14199               
  Branches      577     577               
==========================================
- Hits        11356     650    -10706     
- Misses       2843   13549    +10706
Impacted Files Coverage Δ
.../main/scala/org/apache/openwhisk/core/WarmUp.scala 0.00% <0.00%> (-100.00%) ⬇️
...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala 0.00% <0.00%> (-100.00%) ⬇️
...n/scala/org/apache/openwhisk/utils/JsHelpers.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/common/Prometheus.scala 0.00% <0.00%> (-100.00%) ⬇️
...scala/org/apache/openwhisk/core/FeatureFlags.scala 0.00% <0.00%> (-100.00%) ⬇️
...ala/org/apache/openwhisk/common/ConfigMXBean.scala 0.00% <0.00%> (-100.00%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/common/ConfigMapValue.scala 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/openwhisk/core/entity/WhiskAuth.scala 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/openwhisk/core/entity/EntityPath.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 202 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@style95 style95 merged commit 44379b8 into apache:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ningyougang ningyougang ningyougang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@style95 @codecov-commenter @ningyougang